refactor/test(osmomath): change package of decimal_test.go to osmomath_test #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
A:backport/v13.x
czarcas7ic
approved these changes
Dec 14, 2022
osmomath/decimal_test.go
Outdated
Comment on lines
477
to
496
| func (s *decimalTestSuite) TestPower() { | ||
| testCases := []struct { | ||
| input BigDec | ||
| power uint64 | ||
| expected BigDec | ||
| }{ | ||
| {OneDec(), 10, OneDec()}, // 1.0 ^ (10) => 1.0 | ||
| {NewDecWithPrec(5, 1), 2, NewDecWithPrec(25, 2)}, // 0.5 ^ 2 => 0.25 | ||
| {NewDecWithPrec(2, 1), 2, NewDecWithPrec(4, 2)}, // 0.2 ^ 2 => 0.04 | ||
| {NewDecFromInt(NewInt(3)), 3, NewDecFromInt(NewInt(27))}, // 3 ^ 3 => 27 | ||
| {NewDecFromInt(NewInt(-3)), 4, NewDecFromInt(NewInt(81))}, // -3 ^ 4 = 81 | ||
| {MustNewDecFromStr("1.414213562373095048801688724209698079"), 2, NewDecFromInt(NewInt(2))}, // 1.414213562373095048801688724209698079 ^ 2 = 2 | ||
| } | ||
|
|
||
| for i, tc := range testCases { | ||
| res := tc.input.Power(tc.power) | ||
| s.Require().True(tc.expected.Sub(res).Abs().LTE(SmallestDec()), "unexpected result for test case %d, input: %v", i, tc.input) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I have been a bit removed from these osmomath changes, just wanted to check if Power is getting tested elsewhere?
There was a problem hiding this comment.
Going to submit this removal in: #3712
Got a merge conflict here. Thanks for catching
There was a problem hiding this comment.
This PR lgtm once this is added back!
ValarDragon
approved these changes
Dec 14, 2022
|
ValarDragon
pushed a commit
that referenced
this pull request
Dec 14, 2022
…h_test (#3710) (#3721) * refactor/test(osmomath): change package of decimal_test.go to osmomath_test * restore power test (cherry picked from commit 7da459f) Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards: #3540
What is the purpose of the change
As per title, this is needed to prevent import cycles in tests.
The import cycle I encountered is with
osmoutilsto importErrTolerance.